Switch VariableScope to link directly to its parent #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsholmes
force-pushed
the
fix/scope_link
branch
from
4d57efe
to
cb29ced
Compare
tsholmes
force-pushed
the
fix/scope_link
branch
from
cb29ced
to
5189cad
Compare
Dunbaratu
added a commit
to Dunbaratu/KOS-1
that referenced
this pull request
Oct 29, 2017
TODO list before this becomes ready: [ ] - user docs need to talk about function's scoping changes. [ ] - breaking warning drafted about parameters having been global before but not now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids bouncing back and forth through the stack to find the parent scopes by just linking them directly on creation.
This was meant as a prerequisite to start caching variable lookups, but actually on its own resulted in a ~8% speedup.